-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/sink(ticdc): iterate all Kafka configs to support KOP #8893
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
In addition to these tests, I also tested the multi-topic feature.
[sink]
enable-kafka-sink-v2 = true
dispatchers = [{matcher = ['*.*'], topic = "tidb_{schema}_{table}"}]
mysql> use test;
Database changed
mysql> CREATE TABLE example1 ( id INT PRIMARY KEY, b INT );
Query OK, 0 rows affected (0.15 sec)
mysql> INSERT INTO example1 (id,b) VALUES (2,2);
Query OK, 1 row affected (0.01 sec)
mysql> CREATE TABLE example2 ( id INT PRIMARY KEY, b INT );
Query OK, 0 rows affected (0.09 sec)
mysql> INSERT INTO example2 (id,b) VALUES (2,2);
Query OK, 1 row affected (0.00 sec)
Metadata for all topics (from broker 1960160947: 10.2.xxxx:19092/1960160947):
1 brokers:
broker 1960160947 at 10.2.xxxx7:19092 (controller)
4 topics:
topic "testdsada" with 3 partitions:
partition 0, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 1, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 2, leader 1960160947, replicas: 1960160947, isrs: 1960160947
topic "tidb_test_example2" with 3 partitions:
partition 0, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 1, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 2, leader 1960160947, replicas: 1960160947, isrs: 1960160947
topic "not_exist" with 3 partitions:
partition 0, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 1, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 2, leader 1960160947, replicas: 1960160947, isrs: 1960160947
topic "tidb_test_example1" with 3 partitions:
partition 0, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 1, leader 1960160947, replicas: 1960160947, isrs: 1960160947
partition 2, leader 1960160947, replicas: 1960160947, isrs: 1960160947
kcat -b 10.2.xxxx:19092 -t tidb_test_example2 -o -10000
% Auto-selecting Consumer mode (use -P or -C to override)
{"id":0,"database":"test","table":"example2","pkNames":null,"isDdl":true,"type":"CREATE","es":1683358998100,"ts":1683358998598,"sql":"CREATE TABLE `example2` (`id` INT PRIMARY KEY,`b` INT)","sqlType":null,"mysqlType":null,"data":null,"old":null}
{"id":0,"database":"test","table":"example2","pkNames":["id"],"isDdl":false,"type":"INSERT","es":1683359005400,"ts":1683359005922,"sql":"","sqlType":{"id":4,"b":4},"mysqlType":{"id":"int","b":"int"},"old":null,"data":[{"id":"2","b":"2"}]}
kcat -b 10.2.xxxx:19092 -t tidb_test_example1 -o -10000
% Auto-selecting Consumer mode (use -P or -C to override)
{"id":0,"database":"test","table":"example1","pkNames":null,"isDdl":true,"type":"CREATE","es":1683358986400,"ts":1683358986592,"sql":"CREATE TABLE `example1` (`id` INT PRIMARY KEY,`b` INT)","sqlType":null,"mysqlType":null,"data":null,"old":null}
{"id":0,"database":"test","table":"example1","pkNames":["id"],"isDdl":false,"type":"INSERT","es":1683358992000,"ts":1683358992389,"sql":"","sqlType":{"id":4,"b":4},"mysqlType":{"id":"int","b":"int"},"old":null,"data":[{"id":"2","b":"2"}]} |
/test all |
I tested that both "Standalone" and "Cluster" work. |
/retest |
/test all |
/retest |
baa88ca
to
10f9489
Compare
/merge /test all |
This pull request has been accepted and is ready to merge. Commit hash: 10f9489
|
/test all |
/test pull-dm-integration-test |
@hi-rustin: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test dm-integration-test |
/test all |
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
/cherry-pick release-6.1-20230516-v6.1.3 |
@hi-rustin: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
What problem does this PR solve?
Issue Number: close #8892
What is changed and how it works?
Iterate all Kafka configs to support KOP.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note